Password change#655
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a reusable trait for building password change commands in Sharp. It provides a standardized way for authenticated users to change their own passwords with configurable validation rules, optional password confirmation, and built-in rate limiting protection.
- Adds
IsChangePasswordCommandTraitwith configurable password change functionality - Implements rate limiting (3 attempts) with localized error messages
- Updates demo application to use the new trait instead of custom implementation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Auth/Password/Command/IsChangePasswordCommandTrait.php | New trait providing password change form fields, validation rules, and rate limiting |
| tests/Http/Auth/ChangePasswordCommandTraitTest.php | Comprehensive test coverage for all trait features including rate limiting, confirmation, and validation |
| resources/lang/en/auth.php | English translations for password change command labels and messages |
| resources/lang/fr/auth.php | French translations for password change command labels and messages |
| docs/guide/authentication.md | Documentation explaining trait usage with configuration examples |
| demo/app/Sharp/Profile/ProfileSingleShow.php | Updated to use new command class and modernized array syntax |
| demo/app/Sharp/Profile/Commands/UpdateProfilePasswordCommand.php | Removed legacy custom implementation |
| demo/app/Sharp/Profile/Commands/ChangePasswordCommand.php | New demo implementation using the trait |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an helper (trait) to simplify the creation of a password change command